Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending stat #187

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add pending stat #187

merged 2 commits into from
Apr 24, 2024

Conversation

giskook
Copy link

@giskook giskook commented Apr 23, 2024

Closes #.

What does this PR do?

Reviewers

Main reviewers:

Codeowner reviewers:

  • @-Alice
  • @-Bob

@giskook giskook force-pushed the zhangkai/pending branch 2 times, most recently from 74d7248 to b245873 Compare April 24, 2024 03:55
@zjg555543
Copy link

I think we can add a stat service and db table to save them.

  1. Define a statistics table, with content stored as key-value pairs. For example, key: tx-pending, value: {x:1, b:2}. All statistical information can be written into it.
  2. Implement a statistics service or use an existing one like sync/gp to write to the table.
  3. Other services can read from the table.

@giskook
Copy link
Author

giskook commented Apr 24, 2024

I think we can add a stat service and db table to save them.

Aggree. we need a stat service to do such thing

  1. Define a statistics table, with content stored as key-value pairs. For example, key: tx-pending, value: {x:1, b:2}. All statistical information can be written into it.

Once the stat service setup, we can change the db schema to key-value pairs, now the table schema is hidden by updatePendingStat

@KamiD KamiD merged commit 3667bf0 into release/v0.3.1 Apr 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants